Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging sites: Update learn logo on My Home #95670

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

katinthehatsite
Copy link
Contributor

Related to https://github.com/Automattic/dotcom-forge/issues/9468

Proposed Changes

This PR replaces the logo for the Learn section with the new logo.

Before:

Screenshot 2024-10-24 at 2 38 38 PM

After:

Screenshot 2024-10-24 at 2 38 52 PM

Testing Instructions

  • Navigate to the Calypso live link below
  • Ensure that you have a staging site
  • Navigate to home/{yourStagingSite}
  • In the educational section right below the staging site card, click through to the World-class education by WordPress experts section
  • Confirm that you see the new logo instead of the old one

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@katinthehatsite katinthehatsite self-assigned this Oct 24, 2024
@katinthehatsite katinthehatsite requested a review from a team October 24, 2024 12:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 24, 2024
@katinthehatsite katinthehatsite changed the title Update learn logo Staging sites: Update learn logo on My Home Oct 24, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@fredrikekelund fredrikekelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to clarify the positioning of the logo in the SVG view box, but other than that, this LGTM 👍

Copy link
Contributor

@fredrikekelund fredrikekelund Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really impact Calypso negatively, but the fact that the actual logo is off-center in the view box looks kind of odd on its own.

@matt-west, was this intentional on your part? That the logo should be vertically centered to the subheader, or something like that..?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it is a bit strange but I am guessing because it contains text (compared to all other graphics), perhaps it might be intentional to avoid it looking too cluttered. I am not exactly sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants